Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive when object becomes alias to object of the same type #146

Closed
pawamoy opened this issue Apr 10, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@pawamoy
Copy link
Member

pawamoy commented Apr 10, 2023

Describe the bug
Following #145, replacing a function with an alias to a function should not be detected as a breaking change.
src/duty/callables/__init__.py:31: lazy: Public object points to a different kind of object: function -> alias

Expected behavior
If the alias points to another package, we will need to resolve it (external=True when resolving?).

@pawamoy pawamoy added the bug Something isn't working label Jun 19, 2023
@pawamoy
Copy link
Member Author

pawamoy commented Jul 2, 2023

We now follow aliases when checking API breaking changes, so I'll close this for now, and it could be re-opened as a feature request to automatically load external modules when an alias cannot be resolved, to make sure there's a breaking change or not. The alternative is to just output a warning: "can't resolve alias, possible breaking change".

@pawamoy pawamoy closed this as completed Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant