Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloadable builds (Linux, Windows, Mac) #78

Closed
dcsan opened this issue Aug 2, 2023 · 4 comments
Closed

Downloadable builds (Linux, Windows, Mac) #78

dcsan opened this issue Aug 2, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@dcsan
Copy link

dcsan commented Aug 2, 2023

could you add a build to the downloads area? I'd like to try it out but not sure about getting into the whole guts of doing a build...

(mac user here)

@dcsan dcsan changed the title download a build? downloadable build? Aug 2, 2023
@mkoskim
Copy link
Owner

mkoskim commented Aug 2, 2023

Hi! Absolutely, whenever the editor is somewhat suitable to be packaged.

First: I don't have Mac, and AFAIK I can not do ElectronJS Mac builds on Linux. So, for Mac builds I need someone with Mac to do those for me.

Second: ATM, I am working with "nested editor". SlateJS makes it possible to edit hierarchial data types, and I'd like to use that. Currently, the story is "flattened" to editor component, and "regrouped" back from flat buffer. With nested editing I dont need to do that, and furthermore, it probably makes "folding" (hiding parts you are not working right now) much easier!

So: Lots of work to do, but yes, I try to get downloadable build available as soon as possible.

@mkoskim mkoskim added the enhancement New feature or request label Aug 2, 2023
@mkoskim mkoskim added this to the Basic improvements milestone Aug 2, 2023
@dcsan
Copy link
Author

dcsan commented Aug 2, 2023

folding - so you mean like outliner features? what component libs are you considering?

i tried the slate editor it seems ~ok.

what do you think of monaco?
https://microsoft.github.io/monaco-editor/
it feels nicer to edit with

also there are various block editors like notion some designed for realtime collaboration (CRDT)

https://editorjs.io/
https://news.ycombinator.com/item?id=36957204
https://news.ycombinator.com/item?id=32764493

I was looking for a mindmap component for a project but haven't found anything yet, i might build it with react-flow

@mkoskim
Copy link
Owner

mkoskim commented Aug 2, 2023

folding - so you mean like outliner features? what component libs are you considering?

Editor already has outliner, sort of (it needs more work to be useful). Folding is practise common to code editors, to hide unnecessary details. My previous editor version (written with Python/GTK) does that, and I want this ElectronJS editor to have it, too:

https://en.wikipedia.org/wiki/Code_folding

i tried the slate editor it seems ~ok.

The best/worst part of SlateJS is that it uses browser's internal editor. It has all sorts of quirks you don't see in Visual Code, GoogleDocs or similar.

what do you think of monaco? https://microsoft.github.io/monaco-editor/ it feels nicer to edit with

Yeah, I might switch to some other editor engine at some point. Just reminder, this editor is only meant for writing story manuscripts, nothing else.

also there are various block editors like notion some designed for realtime collaboration (CRDT)

Yes, that's why this one is made with ElectronJS. In some distant future, I might have a server, serving my editor and connecting ppl for real-time collaboration like GoogleDocs. But one step at time :)

I was looking for a mindmap component for a project but haven't found anything yet, i might build it with react-flow

I have plans to integrate more freeform sketches and ideas to the editor. But at the moment, it is only meant to write manuscripts, I keep my sketches and such in other platforms. Some day, yes, but most probably not tomorrow.

@mkoskim mkoskim changed the title downloadable build? Downloadable builds (Linux, Windows, Mac) Aug 6, 2023
@mkoskim mkoskim removed this from the Basic improvements milestone Aug 7, 2023
@mkoskim
Copy link
Owner

mkoskim commented Aug 10, 2023

In the latest releases, I have added manually Linux builds for downloading. At some point I might try Windows builds with Wine, but AFAIK I can't do ElectronJS Mac builds without a Mac computer. Anyways, the best solution would be to set up a CI/CD and let it do release builds automatically.

Issue: #104

Closing this issue, as it is just part of a larger work.

@mkoskim mkoskim closed this as not planned Won't fix, can't repro, duplicate, stale Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants