Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slice renderer window: Display data value and measure distances. #146

Merged
merged 6 commits into from
Jan 4, 2023

Conversation

mlavik1
Copy link
Owner

@mlavik1 mlavik1 commented Dec 18, 2022

Changes to slice renderer window:

  • Added 3 input modes:
    • Move: Move the plane:
    • Inspect: Select a position by clicking, and display data value.
    • Measure: Click and drag to measure distance between two points.
2022-12-18.19-51-32.mp4

This should resolve #145

TODO:

  • Fixed slice view size? (just clamp it instead).
  • Clean up the buttons / UX for adding/removing/switching planes.

@mlavik1
Copy link
Owner Author

mlavik1 commented Dec 18, 2022

@Karthikarc115 does this work for you?
Just check out the "slice-measure" branch, load a volume and go to "Volume rendering" -> "Slice renderer" and click "Add plane".
Also remember that you might need to do some changes to make sure the displayed values are correct, as I mentioned here: #125 (comment)
I'm going to add a setting fort that soon.

@Karthikarc115
Copy link

@Karthikarc115 does this work for you?
Just check out the "slice-measure" branch, load a volume and go to "Volume rendering" -> "Slice renderer" and click "Add plane".
Also remember that you might need to do some changes to make sure the displayed values are correct, as I mentioned here: #125 (comment)
I'm going to add a setting fort that soon.

Sorry i was busy for some time and didn't get time to check it,will do it today

@mlavik1
Copy link
Owner Author

mlavik1 commented Dec 20, 2022

Update:
Slice view now looks like this:
image

Has buttons for adding XY, XZ and ZY planes as well.

Click this button and then click+drag mouse to measure distance:
image

@mlavik1
Copy link
Owner Author

mlavik1 commented Dec 20, 2022

And I've pushed another change, so the measured distance is shown in the correct units.
You can ignore what I said about having to remove that "/ maxScale" in the code.
You should now be able to simply import a dataset, open the slice rendering window, add a slice and measure the distance.
image

Hope that works for you @Karthikarc115

@Karthikarc115
Copy link

And I've pushed another change, so the measured distance is shown in the correct units.
You can ignore what I said about having to remove that "/ maxScale" in the code.
You should now be able to simply import a dataset, open the slice rendering window, add a slice and measure the distance.
image

Hope that works for you @Karthikarc115

Sure will try this

@mlavik1
Copy link
Owner Author

mlavik1 commented Dec 21, 2022

Great! Hope that works for you👍

@mlavik1 mlavik1 merged commit d43c3c5 into master Jan 4, 2023
@mlavik1
Copy link
Owner Author

mlavik1 commented Jan 4, 2023

I'm merging this PR now, since it seems to work fine after doing some testing.
Feel free to let me know if you notice any issues, or if you have further requests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display values and distances in slice rendering window
2 participants