Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor converter for better maintainability and readability #133

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

TaekyungHeo
Copy link
Contributor

@TaekyungHeo TaekyungHeo commented Jul 15, 2024

Summary

Refactor converter for better maintainability and readability

This PR relies on #131

Test Plan

  1. CI passes.
  2. Ran correlation
$ pip install .
Processing /Users/theo/chakra-dev
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: protobuf==4.* in /Users/theo/venv/lib/python3.10/site-packages (from chakra==0.0.4) (4.23.4)
Requirement already satisfied: graphviz in /Users/theo/venv/lib/python3.10/site-packages (from chakra==0.0.4) (0.20.1)
Requirement already satisfied: networkx in /Users/theo/venv/lib/python3.10/site-packages (from chakra==0.0.4) (3.2.1)
Requirement already satisfied: pydot in /Users/theo/venv/lib/python3.10/site-packages (from chakra==0.0.4) (2.0.0)
Requirement already satisfied: pyparsing>=3 in /Users/theo/venv/lib/python3.10/site-packages (from pydot->chakra==0.0.4) (3.1.1)
Building wheels for collected packages: chakra
  Building wheel for chakra (pyproject.toml) ... done
  Created wheel for chakra: filename=chakra-0.0.4-py3-none-any.whl size=55402 sha256=78468b1423f16e442b4cbe02ee73dbf09d75dac52fc50ae552bfe633d17a3ed4
  Stored in directory: /Users/theo/Library/Caches/pip/wheels/1f/cc/a0/f451e6630d3461090be1de9594059abe3c2f5be7ce264deca3
Successfully built chakra
Installing collected packages: chakra
  Attempting uninstall: chakra
    Found existing installation: chakra 0.0.4
    Uninstalling chakra-0.0.4:
      Successfully uninstalled chakra-0.0.4
Successfully installed chakra-0.0.4

$ python3 ci_tools/integration_tests.py --tgz_path tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05.tgz --num_ranks 8 --tolerance 0.05 --expected_times_ms 14597 14597 14968 14638 14649 14700 14677 14735
Extracting tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05.tgz to tests/data/1.0.2-chakra.0.0.4
Running command: chakra_trace_link --chakra-host-trace tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_host_et_0.json --chakra-device-trace tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/kineto_0.json --output-file tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_et_plus_0.json
Running command: chakra_trace_link --chakra-host-trace tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_host_et_1.json --chakra-device-trace tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/kineto_1.json --output-file tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_et_plus_1.json
Running command: chakra_trace_link --chakra-host-trace tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_host_et_2.json --chakra-device-trace tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/kineto_2.json --output-file tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_et_plus_2.json
Running command: chakra_trace_link --chakra-host-trace tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_host_et_3.json --chakra-device-trace tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/kineto_3.json --output-file tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_et_plus_3.json
Running command: chakra_trace_link --chakra-host-trace tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_host_et_4.json --chakra-device-trace tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/kineto_4.json --output-file tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_et_plus_4.json
Running command: chakra_trace_link --chakra-host-trace tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_host_et_5.json --chakra-device-trace tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/kineto_5.json --output-file tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_et_plus_5.json
Running command: chakra_trace_link --chakra-host-trace tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_host_et_6.json --chakra-device-trace tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/kineto_6.json --output-file tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_et_plus_6.json
Running command: chakra_trace_link --chakra-host-trace tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_host_et_7.json --chakra-device-trace tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/kineto_7.json --output-file tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_et_plus_7.json
Running command: chakra_converter --log-filename /tmp/rank_0.log PyTorch --input tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_et_plus_0.json --output tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_final_0.chakra --simulate
Running command: chakra_converter --log-filename /tmp/rank_1.log PyTorch --input tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_et_plus_1.json --output tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_final_1.chakra --simulate
Running command: chakra_converter --log-filename /tmp/rank_2.log PyTorch --input tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_et_plus_2.json --output tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_final_2.chakra --simulate
Running command: chakra_converter --log-filename /tmp/rank_3.log PyTorch --input tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_et_plus_3.json --output tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_final_3.chakra --simulate
Running command: chakra_converter --log-filename /tmp/rank_4.log PyTorch --input tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_et_plus_4.json --output tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_final_4.chakra --simulate
Running command: chakra_converter --log-filename /tmp/rank_6.log PyTorch --input tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_et_plus_6.json --output tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_final_6.chakra --simulate
Running command: chakra_converter --log-filename /tmp/rank_7.log PyTorch --input tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_et_plus_7.json --output tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_final_7.chakra --simulate
Running command: chakra_converter --log-filename /tmp/rank_5.log PyTorch --input tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_et_plus_5.json --output tests/data/1.0.2-chakra.0.0.4/llama_pytorch24.05/chakra_final_5.chakra --simulate
==> rank_0.log <==
DEBUG [07/16/2024 09:04:25 AM] GPU Node ID 301192 on stream 7 completed at 14488271us, tid: stream 7
DEBUG [07/16/2024 09:04:25 AM] Simulation of Chakra node execution completed.

==> rank_1.log <==
DEBUG [07/16/2024 09:05:36 AM] GPU Node ID 301192 on stream 7 completed at 14489195us, tid: stream 7
DEBUG [07/16/2024 09:05:36 AM] Simulation of Chakra node execution completed.

==> rank_2.log <==
DEBUG [07/16/2024 08:55:34 AM] GPU Node ID 301192 on stream 7 completed at 14550790us, tid: stream 7
DEBUG [07/16/2024 08:55:34 AM] Simulation of Chakra node execution completed.

==> rank_3.log <==
DEBUG [07/16/2024 09:02:32 AM] GPU Node ID 301192 on stream 7 completed at 14418327us, tid: stream 7
DEBUG [07/16/2024 09:02:32 AM] Simulation of Chakra node execution completed.

==> rank_4.log <==
DEBUG [07/16/2024 09:02:26 AM] GPU Node ID 301192 on stream 7 completed at 14500584us, tid: stream 7
DEBUG [07/16/2024 09:02:26 AM] Simulation of Chakra node execution completed.

==> rank_5.log <==
DEBUG [07/16/2024 08:58:41 AM] GPU Node ID 301192 on stream 7 completed at 14308678us, tid: stream 7
DEBUG [07/16/2024 08:58:41 AM] Simulation of Chakra node execution completed.

==> rank_6.log <==
DEBUG [07/16/2024 09:02:36 AM] GPU Node ID 301192 on stream 7 completed at 14385408us, tid: stream 7
DEBUG [07/16/2024 09:02:36 AM] Simulation of Chakra node execution completed.

==> rank_7.log <==
DEBUG [07/16/2024 08:57:03 AM] GPU Node ID 301192 on stream 7 completed at 14398107us, tid: stream 7
DEBUG [07/16/2024 08:57:03 AM] Simulation of Chakra node execution completed.

Copy link

github-actions bot commented Jul 15, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@TaekyungHeo TaekyungHeo force-pushed the refactor-converter branch 6 times, most recently from f6b038f to 85e6913 Compare July 16, 2024 12:22
@TaekyungHeo TaekyungHeo added the enhancement New feature or request label Jul 16, 2024
@TaekyungHeo TaekyungHeo marked this pull request as ready for review July 16, 2024 12:25
@TaekyungHeo TaekyungHeo requested a review from a team as a code owner July 16, 2024 12:25
@srinivas212 srinivas212 merged commit 465e8d4 into main Jul 16, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2024
@TaekyungHeo TaekyungHeo deleted the refactor-converter branch July 17, 2024 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants