Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

et_feeder: Bugfix in attr parsing in et_feeder #18

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

TaekyungHeo
Copy link
Contributor

@TaekyungHeo TaekyungHeo commented Feb 6, 2024

Summary

This pull request updates the et_feeder module to fix a critical parsing issue. The problem stemmed from two main sources: inadequate support in protobuf for the oneof boolean value, and a bug within the ETFeederNode::assign_attr_val function.

Test Plan

$ cd ~/param
$ cd param/train/comms/pt
$ pip install .
$ cd ../../compute/python
$ pip install -r requirements.txt
$ python setup.py install
$ python tools/trace_link.py --pytorch-et-file ~/llama_pytorch_et/llama_et_0.json --kineto-file ~/llama_kineto/worker0_step_12.1697596714999.pt.trace.json --output-file ~/rank0.json

$ cd ~/charka
$ pip install .
$ python3 -m chakra.et_converter.et_converter --input_type PyTorch --input_filename ~/rank0.json --output_filename ~/rank0.chakra --num_dims 1 
$ cp ~/rank0.chakra chakra.0.et && cp chakra.0.et chakra.1.et

$ cd ~/astra-sim
$ ./build/astra_analytical/build.sh
$ ./build/astra_analytical/build/bin/AstraSim_Analytical_Congestion_Unaware\
  --workload-configuration=/Users/theo/chakra/chakra\
  --system-configuration=./inputs/system/Switch.json \
  --network-configuration=./inputs/network/analytical/Switch.yml \
  --remote-memory-configuration=./inputs/remote_memory/analytical/no_memory_expansion.json
ring of node 0, id: 0 dimension: local total nodes in ring: 2 index in ring: 0 offset: 1total nodes in ring: 2
ring of node 0, id: 0 dimension: local total nodes in ring: 2 index in ring: 0 offset: 1total nodes in ring: 2
ring of node 0, id: 0 dimension: local total nodes in ring: 2 index in ring: 0 offset: 1total nodes in ring: 2
ring of node 0, id: 0 dimension: local total nodes in ring: 2 index in ring: 0 offset: 1total nodes in ring: 2
sys[0] finished, 7269182000 cycles
sys[1] finished, 7269182000 cycles

@TaekyungHeo TaekyungHeo requested a review from a team as a code owner February 6, 2024 14:30
Copy link

github-actions bot commented Feb 6, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@mlcommons mlcommons deleted a comment from JoongunPark Feb 6, 2024
@mlcommons mlcommons deleted a comment from JoongunPark Feb 6, 2024
@srinivas212 srinivas212 merged commit 06c77a2 into main Feb 6, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
@TaekyungHeo TaekyungHeo deleted the et_feeder branch February 6, 2024 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants