Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable esModule in CJS build #171

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix: disable esModule in CJS build #171

merged 1 commit into from
Oct 20, 2023

Conversation

targos
Copy link
Member

@targos targos commented Oct 20, 2023

Now that we have an ESM facade, it breaks default imports for bundlers.

Now that we have an ESM facade, it breaks default imports for bundlers.
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d71e23f) 71.27% compared to head (60a99a9) 71.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   71.27%   71.27%           
=======================================
  Files          34       34           
  Lines        5295     5295           
  Branches      850      850           
=======================================
  Hits         3774     3774           
  Misses       1516     1516           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@targos targos merged commit bc4ba15 into main Oct 20, 2023
10 checks passed
@targos targos deleted the fix-default-rollup branch October 20, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant