Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dark theme option to confirm button #547

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

guytepper
Copy link
Contributor

When dark mode is on, the ConfirmButton top border remains with a light color.
Screen Shot 2021-04-18 at 16 57 57

The PR changes it to have a darker color:
Screen Shot 2021-04-18 at 16 58 14

(it seems transparent in the picture - however on device it looks great 🌚)

Copy link
Owner

@mmazzarolo mmazzarolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM! 🍡

@mmazzarolo mmazzarolo merged commit f6c1df0 into mmazzarolo:master Apr 18, 2021
github-actions bot pushed a commit that referenced this pull request Apr 18, 2021
## [9.2.1](v9.2.0...v9.2.1) (2021-04-18)

### Bug Fixes

* Added dark theme option to confirm button ([#547](#547)) ([f6c1df0](f6c1df0))
@github-actions
Copy link

🎉 This PR is included in version 9.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@guytepper guytepper deleted the dark-mode-border-color branch April 22, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants