Support iPhone 14 Pro & Pro Max safe area bottom inset #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hey @kolking , thanks, this makes sense sense to me 👍 |
Closed
github-actions bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
# [17.1.0](v17.0.0...v17.1.0) (2023-08-18) ### Features * Support iPhone 14 Pro & Pro Max safe area bottom inset ([#718](#718)) ([cab8968](cab8968))
|
🎉 This PR is included in version 17.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
isIphoneX()method.marginBottomis applied tomodalstyles rather than the cancel button styles. This allows overriding the bottom margin throughmodalStyleIOS.34ptwhich is the proper size of the iOS bottom inset. Reference: iPhone 14 Screen SizesTest Plan
The bottom inset of 34pt should appear for iPhone 14 Pro and iPhone 14 Pro Max. Users should be able to manually update the inset value through
modalStyleIOSprop.