From 2b7166dedeb8760043d41f4e350cf5341967040a Mon Sep 17 00:00:00 2001 From: Michael Rose Date: Mon, 21 Nov 2016 16:01:59 -0500 Subject: [PATCH 1/2] Fix overlapping sidebar navigation list due to `max-height: 100vh` - Use `max-height: 9999px` for smoother animation than `max-height: 100%` - Issue #668 --- _sass/_navigation.scss | 4 ++-- docs/_sass/_navigation.scss | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/_sass/_navigation.scss b/_sass/_navigation.scss index 08ba30e34f9d..a5b301443a22 100644 --- a/_sass/_navigation.scss +++ b/_sass/_navigation.scss @@ -431,7 +431,7 @@ @include breakpoint(max-width ($large - 1px)) { position: relative; max-height: 0; - opacity: 0; + opacity: 0%; overflow: hidden; z-index: 10; -webkit-transition: 0.3s ease-in-out; @@ -446,7 +446,7 @@ .nav__list input:checked ~ .nav__items { -webkit-transition: 0.5s ease-in-out; transition: 0.5s ease-in-out; - max-height: 100vh; + max-height: 9999px; // exaggerate max-height to accommodate tall lists overflow: visible; opacity: 1; margin-top: 1em; diff --git a/docs/_sass/_navigation.scss b/docs/_sass/_navigation.scss index 08ba30e34f9d..a5b301443a22 100644 --- a/docs/_sass/_navigation.scss +++ b/docs/_sass/_navigation.scss @@ -431,7 +431,7 @@ @include breakpoint(max-width ($large - 1px)) { position: relative; max-height: 0; - opacity: 0; + opacity: 0%; overflow: hidden; z-index: 10; -webkit-transition: 0.3s ease-in-out; @@ -446,7 +446,7 @@ .nav__list input:checked ~ .nav__items { -webkit-transition: 0.5s ease-in-out; transition: 0.5s ease-in-out; - max-height: 100vh; + max-height: 9999px; // exaggerate max-height to accommodate tall lists overflow: visible; opacity: 1; margin-top: 1em; From f3bc19a13d33ead62b4f7758ad4f4b005a7d97ff Mon Sep 17 00:00:00 2001 From: Michael Rose Date: Mon, 21 Nov 2016 16:05:52 -0500 Subject: [PATCH 2/2] Update CHANGELOG.md/history and bump vesion to 4.0.9 --- CHANGELOG.md | 6 ++++++ docs/_docs/18-history.md | 8 +++++++- docs/_pages/home.md | 2 +- minimal-mistakes-jekyll.gemspec | 2 +- package.json | 2 +- 5 files changed, 16 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cdd361b94486..4f76f3555493 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ +## [4.0.9](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.0.9) + +### Bug Fixes + +- Fix overlapping sidebar navigation lists due to `max-height: 100vh`. [#668](https://github.com/mmistakes/minimal-mistakes/issues/668) + ## [4.0.8](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.0.8) ### Bug Fixes diff --git a/docs/_docs/18-history.md b/docs/_docs/18-history.md index 14a87ab9e3d5..a6738a38688a 100644 --- a/docs/_docs/18-history.md +++ b/docs/_docs/18-history.md @@ -4,9 +4,15 @@ permalink: /docs/history/ excerpt: "Change log of enhancements and bug fixes made to the theme." sidebar: nav: docs -modified: 2016-11-21T09:54:38-05:00 +modified: 2016-11-21T16:04:45-05:00 --- +## [4.0.9](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.0.9) + +### Bug Fixes + +- Fix overlapping sidebar navigation lists due to `max-height: 100vh`. [#668](https://github.com/mmistakes/minimal-mistakes/issues/668) + ## [4.0.8](https://github.com/mmistakes/minimal-mistakes/releases/tag/4.0.8) ### Bug Fixes diff --git a/docs/_pages/home.md b/docs/_pages/home.md index 982f2fe80ae6..f1dd3c5d4dbe 100644 --- a/docs/_pages/home.md +++ b/docs/_pages/home.md @@ -7,7 +7,7 @@ header: cta_label: " Install Now" cta_url: "/docs/quick-start-guide/" caption: -excerpt: 'A flexible two-column Jekyll theme. Perfect for personal sites, blogs, and portfolios hosted on GitHub or your own server.
Latest release v4.0.8

{::nomarkdown} {:/nomarkdown}' +excerpt: 'A flexible two-column Jekyll theme. Perfect for personal sites, blogs, and portfolios hosted on GitHub or your own server.
Latest release v4.0.9

{::nomarkdown} {:/nomarkdown}' feature_row: - image_path: /assets/images/mm-customizable-feature.png alt: "customizable" diff --git a/minimal-mistakes-jekyll.gemspec b/minimal-mistakes-jekyll.gemspec index bf1888860363..51c2eaeb7ffc 100644 --- a/minimal-mistakes-jekyll.gemspec +++ b/minimal-mistakes-jekyll.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |spec| spec.name = "minimal-mistakes-jekyll" - spec.version = "4.0.8" + spec.version = "4.0.9" spec.authors = ["Michael Rose"] spec.summary = %q{A flexible two-column Jekyll theme.} diff --git a/package.json b/package.json index db0bfa35561a..79e89fd7214a 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "minimal-mistakes", - "version": "4.0.8", + "version": "4.0.9", "description": "Minimal Mistakes Jekyll theme npm build scripts", "repository": { "type": "git",