use an empty value instead of 'no-key'

mmomtchev · Sep 26, 2023 · 4d7fdd6 · 4d7fdd6
1 parent 8ed0ae2
commit 4d7fdd6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
@@ -11,19 +11,19 @@ on:
     workflow_dispatch:
 
 env:
-    STADIA_MAPS_API_KEY: ${{ secrets.STADIA_MAPS_API_KEY || 'no-key' }}
+    STADIA_MAPS_API_KEY: ${{ secrets.STADIA_MAPS_API_KEY }}
 
 jobs:
     default:
         runs-on: ubuntu-latest
 
         steps:
+            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - uses: actions/checkout@v3
             - name: Use Node.js 18.x
               uses: actions/setup-node@v3
               with:
                   node-version: 18.x
-            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - run: npm i
             - run: npm run build --if-present
             - run: npm test
@@ -53,12 +53,12 @@ jobs:
                     - '8.1.0'
 
         steps:
+            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - uses: actions/checkout@v3
             - name: Use Node.js 18.x
               uses: actions/setup-node@v3
               with:
                   node-version: 18.x
-            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - run: npm i
             - run: npm i --force ol@${{ matrix.ol-version }}
             - run: npm run build --if-present
@@ -68,12 +68,12 @@ jobs:
         runs-on: ubuntu-latest
 
         steps:
+            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - uses: actions/checkout@v3
             - name: Use Node.js 18.x
               uses: actions/setup-node@v3
               with:
                   node-version: 18.x
-            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - run: |
                   npm i react@16.8 react-dom@16.8 react-test-renderer@16.8 @types/react@16 @types/react-dom@16 @testing-library/react@11
             - run: npm i
@@ -85,12 +85,12 @@ jobs:
         runs-on: ubuntu-latest
 
         steps:
+            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - uses: actions/checkout@v3
             - name: Use Node.js 18.x
               uses: actions/setup-node@v3
               with:
                   node-version: 18.x
-            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - run: |
                   npm i react@16.14 react-dom@16.14 react-test-renderer@16.14 @types/react@16 @types/react-dom@16 @testing-library/react@11
             - run: npm i
@@ -102,12 +102,12 @@ jobs:
         runs-on: ubuntu-latest
 
         steps:
+            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - uses: actions/checkout@v3
             - name: Use Node.js 18.x
               uses: actions/setup-node@v3
               with:
                   node-version: 18.x
-            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - run: |
                   npm i react@17 react-dom@17 react-test-renderer@17 @types/react@17 @types/react-dom@17 @testing-library/react@11
             - run: npm i
@@ -119,12 +119,12 @@ jobs:
         runs-on: ubuntu-latest
 
         steps:
+            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - uses: actions/checkout@v3
             - name: Use Node.js 18.x
               uses: actions/setup-node@v3
               with:
                   node-version: 18.x
-            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - run: |
                   npm i react@18 react-dom@18 react-test-renderer@18 @types/react@18 @types/react-dom@18 @testing-library/react@13
             - run: npm i
@@ -136,12 +136,12 @@ jobs:
         runs-on: ubuntu-latest
 
         steps:
+            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - uses: actions/checkout@v3
             - name: Use Node.js 18.x
               uses: actions/setup-node@v3
               with:
                   node-version: 18.x
-            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - run: |
                   npm i react@18.1 react-dom@18.1 react-test-renderer@18.1 @types/react@18 @types/react-dom@18 @testing-library/react@13
             - run: npm i
@@ -153,12 +153,12 @@ jobs:
         runs-on: ubuntu-latest
 
         steps:
+            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - uses: actions/checkout@v3
             - name: Use Node.js 18.x
               uses: actions/setup-node@v3
               with:
                   node-version: 18.x
-            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - run: |
                   npm i react@18.2 react-dom@18.2 react-test-renderer@18.2 @types/react@18 @types/react-dom@18 @testing-library/react@13
             - run: npm i
@@ -170,12 +170,12 @@ jobs:
         runs-on: ubuntu-latest
 
         steps:
+            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - uses: actions/checkout@v3
             - name: Use Node.js 18.x
               uses: actions/setup-node@v3
               with:
                   node-version: 18.x
-            - run: echo "::add-mask::${{ secrets.STADIA_MAPS_API_KEY }}"
             - run: npm i
             - run: npm run test
               env:

diff --git a/test/RLayerMisc.test.tsx b/test/RLayerMisc.test.tsx
@@ -16,7 +16,7 @@ import RLayerStadia from 'rlayers/layer/RLayerStadia';
 
 import * as common from './common';
 
-if (semver.gte(VERSION, '8.0.0') && process.env.STADIA_MAPS_API_KEY !== 'no-key') {
+if (semver.gte(VERSION, '8.0.0') && process.env.STADIA_MAPS_API_KEY !== '') {
     describe('<RLayerStadia>', () => {
         it('should display a tiled Stadia layer', () => {
             const layer = React.createRef() as React.RefObject<RLayerStadia>;