-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using a dynamic RStyle
in React 18 triggers a warning in the console
#40
Comments
I am still looking for a way to support both React 17 and React 18 style rendering in a proper manner. Until then, the warning should be ignored as it has no real functional consequence - it does not apply to the rendering of the DOM, only to the off-screen rendering of the dynamic styles - your application will still use React 18 rendering. |
Any updates on this issue? |
There is no other solution besides dropping support for React 17 and earlier, will probably happen at the next major version |
Okay, thanks for the update! |
Hi @mmomtchev, do you foresee this having any impact within a nextjs 13 environment with its heavy reliance on react 18 voodoo? |
This warning has no effect, but the one from #112 does. Do not use dynamic inline styles if you get it - everything that can be expressed with a dynamic inline style, can also be expressed with a traditional Openlayers style function. |
Any updates on this issue? |
I do not plan to drop support for React 16/17 only to remove a console.warning when using a relatively obscure feature |
When using a dynamic
RStyle
with arender
prop in React 18 in development mode, there is a warning in the console:The text was updated successfully, but these errors were encountered: