Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Use pooch for web downloads #771

Closed
larsoner opened this issue Jul 20, 2023 · 1 comment · Fixed by #775
Closed

MAINT: Use pooch for web downloads #771

larsoner opened this issue Jul 20, 2023 · 1 comment · Fixed by #775

Comments

@larsoner
Copy link
Member

@hoechenberger any reason you didn't use pooch for the ~50 lines in _download.py? Seems like we would get some minus lines plus more robustness/maintained-ness by using pooch.
@hoechenberger
Copy link
Member

I don't remember. If you think it can be replaced using pooch, please do go for it!

@larsoner larsoner mentioned this issue Aug 7, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MAINT: Use pooch for downloading web data larsoner/mne-bids-pipeline
2 participants
@hoechenberger @larsoner