Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Mark steps as optional in flowchart #861

Closed
larsoner opened this issue Feb 26, 2024 · 1 comment · Fixed by #865
Closed

DOC: Mark steps as optional in flowchart #861

larsoner opened this issue Feb 26, 2024 · 1 comment · Fixed by #865

Comments

@larsoner
Copy link
Member

larsoner commented Feb 26, 2024

@larsoner is the 'temporal regression for artifact removal' a default step? I am not aware that I am using it.

If not, I think it should be marked as optional.

Originally posted by @SophieHerbst in #860 (comment)

@larsoner larsoner changed the title ENH: Mark steps as optional in flowchart DOC: Mark steps as optional in flowchart Feb 26, 2024
@larsoner
Copy link
Member Author

In some sense almost all steps are optional. Like if you set l_freq = None (default) and h_freq = None (not default!) there is no frequency filtering, spatial_filter = None (default) skips SSP and ICA, etc. I'll add a note to #865 along these lines. After that I think that documenting better which config options affect which steps is probably the best we can do (?), in which case this would be a dup of #862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant