Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIDS sample and value columns will be considered "arbitrary" columns soon #1130

Closed
sappelhoff opened this issue Apr 11, 2023 · 1 comment · Fixed by #1132
Closed

BIDS sample and value columns will be considered "arbitrary" columns soon #1130

sappelhoff opened this issue Apr 11, 2023 · 1 comment · Fixed by #1132
Assignees
Milestone

Comments

@sappelhoff
Copy link
Member

as discussed in:

and implemented in:

the currently OPTIONAL sample and value columns in *_events.tsv files will be demoted to "arbitrary" columns in BIDS 1.9.0.

Practically this means, that mne-bids should write entries into *_events.json, defining how we use sample and value.

Otherwise, datasets produced by mne-bids might soon generate a "warning" (not an error 😉 ) that sample and value are undefined.

@sappelhoff sappelhoff added this to the 0.13 milestone Apr 11, 2023
@agramfort
Copy link
Member

agramfort commented Apr 11, 2023 via email

@hoechenberger hoechenberger self-assigned this Apr 22, 2023
hoechenberger added a commit to hoechenberger/mne-bids that referenced this issue Apr 22, 2023
hoechenberger added a commit to hoechenberger/mne-bids that referenced this issue Apr 22, 2023
hoechenberger added a commit to hoechenberger/mne-bids that referenced this issue Apr 23, 2023
hoechenberger added a commit to hoechenberger/mne-bids that referenced this issue Apr 23, 2023
hoechenberger added a commit to hoechenberger/mne-bids that referenced this issue Apr 23, 2023
hoechenberger added a commit to hoechenberger/mne-bids that referenced this issue Apr 23, 2023
sappelhoff added a commit that referenced this issue Apr 25, 2023
…es (#1132)

Write events.json with "sample", "value", and "trial_type" entries

Fixes #1130

Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants