Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable test in CIs when noble build of LSL is available #345

Closed
mscheltienne opened this issue Oct 16, 2024 · 3 comments
Closed

Re-enable test in CIs when noble build of LSL is available #345

mscheltienne opened this issue Oct 16, 2024 · 3 comments

Comments

@mscheltienne
Copy link
Member

mscheltienne commented Oct 16, 2024

PR #343 skips a test on linux CIs since ubuntu-latest updated to 24.04 LTS and LSL did not yet release a 24.04 build.

@pytest.mark.skipif(
_PLATFORM == "linux",
reason="Runner ubuntu-latest runs on 24.04 and LSL did not release yet for it.",
)

depends on:

@larsoner
Copy link
Member

Just thinking out loud... is there a reason we don't make mne-lsl a cibuildwheel project and compile liblsl ourselves using abi3? It's a bit more maintenance overhead but I'm not sure why LSL needs to build for different platforms. cffi might make this pretty easy (it even sets the ABI flags during compilation), it's what is used in python-rtmixer for example.

@mscheltienne
Copy link
Member Author

No reason beside the added maintenance. I don't know if we would need platform-specific wheels.

@larsoner
Copy link
Member

I don't know if we would need platform-specific wheels.

Yeah we would if we bundled liblsl but I think that could be okay. I might give it a shot and see how bad it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants