Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: exec API should support sending signals to processes #2566

Closed
tonistiigi opened this issue Jan 18, 2022 · 2 comments · Fixed by #2590
Closed

gateway: exec API should support sending signals to processes #2566

tonistiigi opened this issue Jan 18, 2022 · 2 comments · Fixed by #2590

Comments

@tonistiigi
Copy link
Member

#1627 added capability to run and exec into containers via gateway API. This was released in v0.8 .

The capability to send/forward signals as part of the API was not part of the initial commit and only has a TODO comment

// TODO Signal(ctx context.Context, sig os.Signal)

This makes it harder reliably use this API as signals are a very common part of process workflow. For TTY, some cases like closing the process can be worked around with EOF.

We should try to add the missing API asap, hopefully in v0.10 milestone. This is needed if we want to move on with #1472 and missing it would mean that a full buildkit update cycle is needed to test such features.

@coryb

@tonistiigi
Copy link
Member Author

@coryb Do you think you would have time to take this on?

@coryb
Copy link
Collaborator

coryb commented Jan 31, 2022

I have done some work on this already, will hopefully have a PR this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants