Merge pull request #2110 from joshlory/stringify-fix

Fix #2109: stringify should handle objects with non-coercible length
mochajs · Mar 20, 2016 · 61fbb7f · 61fbb7f
2 parents 9ae6a85 + 3b92fcc
commit 61fbb7f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/utils.js b/lib/utils.js
@@ -454,7 +454,7 @@ function jsonStringify(object, spaces, depth) {
   var space = spaces * depth;
   var str = isArray(object) ? '[' : '{';
   var end = isArray(object) ? ']' : '}';
-  var length = object.length || exports.keys(object).length;
+  var length = typeof object.length === 'number' ? object.length : exports.keys(object).length;
   // `.repeat()` polyfill
   function repeat(s, n) {
     return new Array(n).join(s);

diff --git a/test/acceptance/utils.js b/test/acceptance/utils.js
@@ -340,6 +340,10 @@ describe('lib/utils', function () {
         stringify({symbol: symbol}).should.equal('{\n  "symbol": Symbol(value)\n}')
       });
     }
+
+    it('should handle length properties that cannot be coerced to a number', function () {
+      stringify({length: {toString: 0}}).should.equal('{\n  "length": {\n    "toString": 0\n  }\n}');
+    });
   });
 
   describe('type', function () {