Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #865: Disable timeouts when running under the debug #1262

Merged

Conversation

jsdevel
Copy link
Contributor

@jsdevel jsdevel commented Jul 8, 2014

This works, but will probably generate criticism related to style and semantics etc.

Please let me know what you think. Thanks.

@jsdevel
Copy link
Contributor Author

jsdevel commented Jul 11, 2014

@jonathanong @travisjeffery this change adds a --disable-timeouts option which is added implicitly whenever a debuggish (I.E. --debug-brk) option is detected in mocha. I think a --disable-timeouts option has it's use cases, like for long running selenium tests etc. Let me know if you'd like me to change the commit message to reflect this or if there's any style change you'd like to see. Thanks!

@jbnicolai
Copy link

Looks good to me 👍

@jsdevel
Copy link
Contributor Author

jsdevel commented Jul 12, 2014

Thanks @jbnicolai!

@jbnicolai
Copy link

No feedback from any of the others, but I'm happy to merge this.

jbnicolai pushed a commit that referenced this pull request Jul 13, 2014
…tion-is-set

closes #865: Disable timeouts when running under the debug
@jbnicolai jbnicolai merged commit 880d451 into mochajs:master Jul 13, 2014
@jsdevel jsdevel deleted the disabling-timeout-when-debug-option-is-set branch July 13, 2014 03:54
@jsdevel
Copy link
Contributor Author

jsdevel commented Jul 13, 2014

Thanks @jbnicolai!

@travisjeffery
Copy link
Contributor

there should be an api added for this, like the other options. mocha.invert(), mocha.suite.timeout(timeout), mocha.grep(/re/), mocha.asyncOnly(), etc. to not do this: jsdevel@fa3fa4d#diff-789b16a197fe1df6ad7686554bb32265R235.

@jsdevel
Copy link
Contributor Author

jsdevel commented Jul 13, 2014

@travisjeffery see #1268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants