Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML reporter: preserve query params when navigating to suites/tests #1358

Merged
merged 1 commit into from
Oct 17, 2014

Conversation

boneskull
Copy link
Contributor

PR #830 is woefully out-of-date, but we never fixed the issue, so this fixes the issue. To test:

  1. Open browser test
$ open test/browser/index.html
  1. Assert clicking on a suite drills-down to the suite
  2. Assert clicking on a test drills-down to the test
  3. Repeat step 1; ensure no querystring is present in URL
  4. Append ?foo=bar to URL in browser
  5. Repeat steps 2-3, asserting ?foo=bar remains in URL

boneskull pushed a commit that referenced this pull request Oct 17, 2014
HTML reporter: preserve query params when navigating to suites/tests
@boneskull boneskull merged commit 9b747db into mochajs:master Oct 17, 2014
@boneskull boneskull deleted the queryparams branch October 17, 2014 07:32
@boneskull boneskull restored the queryparams branch October 17, 2014 07:54
jlfwong referenced this pull request Oct 22, 2014
@vsiao
Copy link

vsiao commented Dec 16, 2014

This can result in ?grep=foo&grep=bar&grep=baz if you keep clicking URLs in the HTML reporter. #830 ignores existing grep params, which is preferable.

@boneskull boneskull deleted the queryparams branch June 9, 2016 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants