support escaped spaces in cli options #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm unclear why you can't just use double-quotes? Anyway, this looks ok to me. |
| @@ -22,9 +22,10 @@ function getOptions() { | |||
| try { | |||
| var opts = fs.readFileSync(optsPath, 'utf8') | |||
| .trim() | |||
| .replace(/\\\s+/, '%20') | |||
There was a problem hiding this comment.
- The
+would turn an escaped space followed by one or multiple unescaped spaces into a single'%20'. - The lack of a
//gflag would make this regex only transform the first escaped whitespace and leave all others
E.g.:
"foo bar\\ \\ baz\\ boo".replace(/\\\s+/, '%20')
"foo bar%20\ baz\ boo"
I agree, I would always go for quoting as well. On the other hand, supporting escaped whitespaces is pretty standard as well, so why not ;)
It looks pretty broken to me 😛 |
| @@ -22,9 +22,10 @@ function getOptions() { | |||
| try { | |||
| var opts = fs.readFileSync(optsPath, 'utf8') | |||
| .trim() | |||
There was a problem hiding this comment.
If the string ends with "\\ " trim will remove the trailing space. Edge case, I admit, but these two lines should be swapped.
|
And this is why I shouldn't code late at night. 😜 Thanks for the feedback, I'll fix it. |
adamgruber
force-pushed
the
master
branch
2 times, most recently
from
0891077 to
d8873c7
Compare
|
Made the changes and cleaned up the history. |
|
👍 thanks! |
jbnicolai
pushed a commit
that referenced
this pull request
Jul 4, 2015
support escaped spaces in cli options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current parsing of options does not allow spaces within an option so this fixes that. This is particularly useful in the case of reporter options where a custom reporter may want to accept a string option that contains a space.
See adamgruber/mochawesome#20 for an example.
This patch would require any spaces to be escaped like
--option option\ with\ spaces