Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis "before script" should only be run once #3208

Closed
boneskull opened this issue Jan 18, 2018 · 6 comments · Fixed by #3214
Closed

travis "before script" should only be run once #3208

boneskull opened this issue Jan 18, 2018 · 6 comments · Fixed by #3214
Assignees
Labels
good first issue new contributors should look here! status: accepting prs Mocha can use your help with this one! type: chore generally involving deps, tooling, configuration, etc.

Comments

@boneskull
Copy link
Contributor

This script basically asserts define doesn't appear in the browser distfile (mocha.js).

  • This check probably needs to have its own line in the build matrix
  • It should be invoked via a script in package-scripts.js so developers can run it locally
@boneskull boneskull added status: accepting prs Mocha can use your help with this one! type: chore generally involving deps, tooling, configuration, etc. qa good first issue new contributors should look here! labels Jan 18, 2018
@vkarpov15
Copy link
Contributor

@boneskull I'm not sure which script you're talking about, can you clarify?

@boneskull
Copy link
Contributor Author

scripts/travis-before-script.sh

@Bamieh
Copy link
Contributor

Bamieh commented Jan 19, 2018

I'll check it out later on today
@outsideris wants to work on it

@Bamieh Bamieh self-assigned this Jan 19, 2018
@outsideris
Copy link
Contributor

@Bamieh Oops. I'm trying to fix it. Can I submit for PR for this?

@outsideris
Copy link
Contributor

I worried about you are working on it.

@Bamieh
Copy link
Contributor

Bamieh commented Jan 20, 2018

@outsideris thanks for helping out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue new contributors should look here! status: accepting prs Mocha can use your help with this one! type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants