Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--watch-extensions needs to default to 'js' #3336

Closed
boneskull opened this issue Apr 18, 2018 · 0 comments
Closed

--watch-extensions needs to default to 'js' #3336

boneskull opened this issue Apr 18, 2018 · 0 comments
Labels
good first issue new contributors should look here! status: accepting prs Mocha can use your help with this one! type: bug a defect, confirmed by a maintainer
Milestone
v6.0.0

Comments

@boneskull
Copy link
Contributor

boneskull commented Apr 18, 2018 •
edited
Loading

The change in c580294 to --watch-extensions (published accidentally in v5.1.0) fails to set a default value.

If --watch-extensions is not specified, it should default to .js; otherwise use whatever was specified.

PRs should target master as usual.
@boneskull boneskull added type: bug a defect, confirmed by a maintainer status: accepting prs Mocha can use your help with this one! good first issue new contributors should look here! labels Apr 18, 2018
@boneskull boneskull added this to the v6.0.0 milestone Apr 18, 2018
@boneskull boneskull changed the title release/v6.0.x: --watch-extensions needs to default to 'js' --watch-extensions needs to default to 'js' Apr 18, 2018
boneskull referenced this issue Apr 19, 2018
@TheDancingCode @boneskull
remove default js in "--watch-extensions" option; closes #3275
c580294
plroebuck added a commit to plroebuck/mocha that referenced this issue Apr 21, 2018
@plroebuck
fix(bin/_mocha): Make --watch-extensions default to 'js'
a0a2bd3 
The change in c580294 to `--watch-extensions` failed to set a default value. This change specifies
that default value.

Fixes mochajs#3336
@plroebuck plroebuck mentioned this issue Apr 21, 2018
Closed
boneskull pushed a commit that referenced this issue May 18, 2018
@plroebuck @boneskull
fix(bin/_mocha): Make --watch-extensions default to 'js'
087dad1 
The change in c580294 to `--watch-extensions` failed to set a default value. This change specifies
that default value.

Fixes #3336
sgilroy pushed a commit to TwineHealth/mocha that referenced this issue Feb 27, 2019
@plroebuck @boneskull
fix(bin/_mocha): Make --watch-extensions default to 'js'
89d5cb6 
The change in c580294 to `--watch-extensions` failed to set a default value. This change specifies
that default value.

Fixes mochajs#3336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue new contributors should look here! status: accepting prs Mocha can use your help with this one! type: bug a defect, confirmed by a maintainer
Projects
None yet
Milestone
v6.0.0
Development

No branches or pull requests
1 participant
@boneskull