Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ssertionError" should be AssertionError #334

Closed
topfunky opened this issue Mar 20, 2012 · 3 comments
Closed

"ssertionError" should be AssertionError #334

topfunky opened this issue Mar 20, 2012 · 3 comments

Comments

@topfunky
Copy link

I think this is a Mocha bug, but it may be in Node's assertion module.

Many failing tests show ssertionError instead of AssertionError.

Steps to reproduce:

Write a failing test such as:

assert.equal 4, 2

Output:

ssertionError: 4 == 2

Expected output:

AssertionError: 4 == 2

Also:

  • Why does it say "4 == 2"? It should say that "4 != 2".
@tj
Copy link
Contributor

tj commented Mar 20, 2012

hmm i'll check that out in a minute, the error messages themselves are up to node core though that's not mocha

@tj tj closed this as completed in 8ac5184 Mar 20, 2012
@tj
Copy link
Contributor

tj commented Mar 20, 2012

but yeah I guess node's assert reports the failed assertion as in "assertion of 4 == 2" failed, instead of negating, I dont use it much other than assert(foo == bar, 'msg')

@topfunky
Copy link
Author

Sweet! Thanks for the leading character fix. Looks much more pro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants