fix sponsors background color for readability #3988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I removed blur. |
Signed-off-by: Outsider <outsideris@gmail.com>
Signed-off-by: Outsider <outsideris@gmail.com>
Signed-off-by: Outsider <outsideris@gmail.com>
outsideris
force-pushed
the
sponsor-bg
branch
from
53bf3e3 to
2fc42d2
Compare
|
Resolved conflicts. And make sponsor's background like code block style. IMO it's more natural.
|
|
I will merge this in a few days. |
outsideris
added
the
semver-patch
outsideris
added a commit
that referenced
this pull request
Nov 2, 2019
Signed-off-by: Outsider <outsideris@gmail.com>
outsideris
removed
the
landed-on-v6.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
If sponsors use white-tone logo, users can't see the sponsor's logo.
So, I added grey background to sponsors.(And align them center)
I knew it is not pretty design, but grey is best for both light-tone and dark-tone logos. I thought making sponsor logos readable is more important than pretty design.
Alternate Designs
Another color or design?
Applicable issues
close #3736