Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove configuration via 'mocha.opts' #4175

Merged
merged 3 commits into from
Mar 12, 2020
Merged

Remove configuration via 'mocha.opts' #4175

merged 3 commits into from
Mar 12, 2020

Conversation

juergba
Copy link
Contributor

@juergba juergba commented Feb 4, 2020

Description

The configuration via mocha.opts has been deprecated in Mocha v7.0.0.
In Mocha v8.0.0 we remove it.

Description of the Change

  • we remove corresponding code, unit and integration tests
  • we adapt docs
  • Mocha does not complain, when an unknown/mistyped option is used. Many user do not read our documentation/release notes, therefore we throw an error when user sets --opts option.

@juergba juergba added type: feature enhancement proposal area: usability concerning user experience or interface semver-major implementation requires increase of "major" version number; "breaking changes" area: node.js command-line-or-Node.js-specific block labels Feb 4, 2020
@juergba juergba added this to the v8.0.0 milestone Feb 4, 2020
@juergba juergba requested a review from a team February 4, 2020 17:09
@juergba juergba self-assigned this Feb 4, 2020
@coveralls
Copy link

coveralls commented Feb 4, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 92.804% when pulling 54e3c89 on juergba/remove-opts into 6aeeb33 on master.

@juergba juergba force-pushed the juergba/remove-opts branch from 0c21c42 to db15b51 Compare February 9, 2020 07:34
@juergba
Copy link
Contributor Author

juergba commented Feb 9, 2020 •
edited
Loading

coverage: the report shows a decrease of -0.06% in lib/cli/options.js. When studying the details there is not one uncovered line of code, and the three newly added lines are covered by tests.
So IMO no need for action.

@juergba juergba marked this pull request as ready for review February 9, 2020 08:14
@juergba juergba force-pushed the juergba/remove-opts branch from db15b51 to 003e8bb Compare February 9, 2020 08:30
@juergba juergba force-pushed the juergba/remove-opts branch from 003e8bb to fa8dae9 Compare February 27, 2020 07:25
@juergba juergba force-pushed the juergba/remove-opts branch from fa8dae9 to 54e3c89 Compare March 12, 2020 15:38
@juergba juergba removed block type: feature enhancement proposal labels Mar 12, 2020
@juergba juergba merged commit 2f26478 into master Mar 12, 2020
@juergba juergba deleted the juergba/remove-opts branch March 12, 2020 16:41
@webzwo0i webzwo0i mentioned this pull request Jan 29, 2021
Closed
bpinto added a commit to bpinto/kefir-test-utils that referenced this pull request Nov 15, 2021
@bpinto
Replace deprecated mocha.opts
7d673d7 
Ref: mochajs/mocha#4175
bpinto added a commit to bpinto/kefir-test-utils that referenced this pull request Nov 15, 2021
@bpinto
Replace deprecated mocha.opts
f9a2fcf 
Ref: mochajs/mocha#4175
mAAdhaTTah pushed a commit to kefirjs/kefir-test-utils that referenced this pull request Nov 16, 2021
@bpinto
Mocha v9 (#354)
03d5037 
* mocha@9.1.3

* Replace deprecated mocha.opts

Ref: mochajs/mocha#4175

* Remove dependabot exclusion
@t4110 t4110 mentioned this pull request Apr 26, 2022
Closed
@mfranzke mfranzke mentioned this pull request Mar 12, 2023
Draft
76 tasks
@Omrisnyk Omrisnyk mentioned this pull request Dec 7, 2023
Open
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Oct 30, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsideris outsideris outsideris approved these changes

Assignees

@juergba juergba

Labels
area: node.js command-line-or-Node.js-specific area: usability concerning user experience or interface semver-major implementation requires increase of "major" version number; "breaking changes"
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@juergba @coveralls @outsideris