Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better debug output #4236

Merged
merged 1 commit into from
Apr 24, 2020
Merged

better debug output #4236

merged 1 commit into from
Apr 24, 2020

Conversation

boneskull
Copy link
Contributor

  • make sure that template strings aren't used in debug statements, since they are eager

Ref: #4198

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

@boneskull boneskull added type: chore generally involving deps, tooling, configuration, etc. semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Apr 21, 2020
@boneskull boneskull self-assigned this Apr 21, 2020
@boneskull boneskull mentioned this pull request Apr 21, 2020
Closed
22 tasks
@juergba
Copy link
Contributor

juergba commented Apr 22, 2020

make sure that template strings aren't used in debug statements, since they are eager

I don't understand this statement.

arvidOtt
arvidOtt suggested changes Apr 22, 2020
View reviewed changes
lib/cli/config.js Outdated Show resolved Hide resolved
@boneskull
Copy link
Contributor Author

make sure that template strings aren't used in debug statements, since they are eager

I don't understand this statement.

@juergba I mean that a template literal is always evaluated regardless. If debug is not enabled, the string containing placeholders won't be evaluated. The impact is probably minimal in our case, but IMO it's good practice.

@boneskull boneskull force-pushed the boneskull/issue/2839-debug-output branch from d8979e0 to eddf2e4 Compare April 22, 2020 18:37
juergba
juergba reviewed Apr 24, 2020
View reviewed changes
bin/mocha Show resolved Hide resolved
lib/cli/config.js Show resolved Hide resolved
lib/cli/options.js Show resolved Hide resolved
@boneskull
better debug output
2ef600e 
- make sure that template strings aren't used in debug statements, since they are eager

Ref: #4198
@boneskull boneskull force-pushed the boneskull/issue/2839-debug-output branch from eddf2e4 to 2ef600e Compare April 24, 2020 18:40
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 93.102% when pulling 2ef600e on boneskull/issue/2839-debug-output into 5f9400d on master.

@boneskull
Copy link
Contributor Author

this is low-impact, so merging

@boneskull boneskull merged commit a2efd11 into master Apr 24, 2020
@craigtaub craigtaub added this to the next milestone May 21, 2020
@juergba juergba deleted the boneskull/issue/2839-debug-output branch January 29, 2021 08:41
@Omrisnyk Omrisnyk mentioned this pull request Dec 7, 2023
Open
@tpicard586 tpicard586 mentioned this pull request Jul 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juergba juergba juergba left review comments

@arvidOtt arvidOtt arvidOtt requested changes

@raymondfeng raymondfeng raymondfeng approved these changes

Assignees

@boneskull boneskull

Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
v7.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@boneskull @juergba @coveralls @raymondfeng @arvidOtt @craigtaub