Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency 'wide-align' #4754

Merged
merged 2 commits into from
Sep 24, 2021
Merged

Remove dependency 'wide-align' #4754

merged 2 commits into from
Sep 24, 2021

Conversation

juergba
Copy link
Contributor

@juergba juergba commented Sep 23, 2021

Description

see #4748 (comment) @jimmywarting

  • remove dependency wide-align
  • use String.prototype.padEnd() instead
  • rebuild package-lock.json

@juergba juergba added type: chore generally involving deps, tooling, configuration, etc. dependencies Pull requests that update a dependency file semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Sep 23, 2021
@juergba juergba added this to the next milestone Sep 23, 2021
@juergba juergba self-assigned this Sep 23, 2021
@juergba juergba requested a review from a team September 23, 2021 07:09
jimmywarting
jimmywarting approved these changes Sep 23, 2021
View reviewed changes
Copy link

@jimmywarting jimmywarting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@juergba juergba merged commit a87461c into master Sep 24, 2021
@juergba juergba deleted the juergba/wide-align branch September 24, 2021 14:02
This was referenced May 21, 2024
Open
Open
Open
@leonmonson leonmonson mentioned this pull request Jul 27, 2024
Open
@federicomoneta federicomoneta mentioned this pull request Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmywarting jimmywarting jimmywarting approved these changes

Assignees

@juergba juergba

Labels
dependencies Pull requests that update a dependency file semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
v9.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@juergba @jimmywarting