Fix: potential call-stack crash when using 'dry-run' option #4839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juergba
added
the
semver-patch
KuznetsovRoman
pushed a commit
to gemini-testing/mocha
that referenced
this pull request
Sep 6, 2022
This was referenced Jul 16, 2024
This was referenced Jul 22, 2024
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dry-runmode: since the tests are not executed, but triggered only into an empty synchronous run, there is a potential risk ofRangeError: Maximum call stack size exceeded.Description of the Change
For each test we add an asynchronous function call with
Runner.immediately(). We pay a slight performance costs for this which is insignificant indry-runmode.Applicable issues
closes #4838