Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Repo: Set up commit/PR linting to (only) enforce PR titles, per squash merging #5054

Closed
5 tasks done
JoshuaKGoldberg opened this issue Dec 27, 2023 · 2 comments
Closed
5 tasks done
Assignees
Labels
area: repository tooling concerning ease of contribution status: accepting prs Mocha can use your help with this one!

Comments

@JoshuaKGoldberg
Copy link
Member

Tooling Suggestion Checklist

Overview

Following #5038 (comment):

We're discussing this now. Our consensus is:

  1. We don't believe the benefits of a pristine Git history to be worth the cost of asking everyone to maintain that history
  2. Squash merging PRs using their title + description preserves a relatively clean history
  3. We'll switch to squash merging always, and only enforcing conventions on the PR title
  4. We can therefore remove commit linting for anything other than file formatting

Filing this issue to track setting up new / updating any existing workflows to match this preference.

Additional Info

No response

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Mocha can use your help with this one! area: repository tooling concerning ease of contribution labels Dec 27, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 27, 2023
@JoshuaKGoldberg JoshuaKGoldberg moved this from Up Next to In Progress in Maintenance Reboot Feb 8, 2024
@JoshuaKGoldberg
Copy link
Member Author

#5077 started on this.

@JoshuaKGoldberg
Copy link
Member Author

I believe that was all we needed, actually! Closing out. 🙂

@github-project-automation github-project-automation bot moved this from In Progress to Done in Maintenance Reboot Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: repository tooling concerning ease of contribution status: accepting prs Mocha can use your help with this one!
Projects
Development

No branches or pull requests

1 participant