🚀 Feature: Change default value for --watch-ignore to **/node_modules, **/.git

[jedwards1211]

Feature Request Checklist

• I have read and agree to Mocha's Code of Conduct and Contributing Guidelines
• I have searched for related issues and issues with the faq label, but none matched my issue.
• I want to provide a PR to resolve this

Overview

In monorepos and other projects that have node_modules and/or .git directories deeper than the root, mocha --watch watches the contents of these directories by default.

(You may say, but in a monorepo you're just running tests in the directory for each individual package, where its node_modules lives, right? But sometimes you want to run integration tests that combine multiple packages in the monorepo.)

This generally causes mocha --watch to take a long time to start up, with no clear indication why.

Suggested Solution

If we changed the default watch-ignore to ["**/node_modules", "**/.git"] it would automatically ignore all such directories

Alternatives

Of course we can override this in userland, but I think it would benefit everyone to just ignore all node_modules and .git directories by default.

Additional Info

No response

[JoshuaKGoldberg]

This sounds very reasonable to me, you have my 👍 vote!

For reference, the documented default right now is [array] [default: ["node_modules",".git"]].

[jedwards1211]

@JoshuaKGoldberg okay thanks! I made a PR: #5204

[JoshuaKGoldberg]

Oh, sorry, I was unclear - that's just one vote from me. We'll still need consensus from @mochajs/maintenance-crew. This is still in triage.

It also could be considered a breaking change, so it might be a while before we can land it.

[JoshuaKGoldberg]

Coming back to this: no inputs from other folks, so I'm taking the executive step of saying 👍 on changing the default as a breaking change. Tentatively that looks like it'll be for Mocha 12.

Sibling issue for --ignore: #5131.