Growl reporter fails due to recursive structure

[fb55]

Hi,

I'm using mocha for CSSselect and for some reason, the growl reporter doesn't work.

The project uses the exports style.

feedy:CSSselect felix$ mocha -R growl --watch


/usr/local/share/npm/lib/node_modules/mocha/node_modules/growl/lib/growl.js:197
      args.push(quote(msg));
                ^
TypeError: Converting circular structure to JSON
    at stringify (native)
    at new growl (/usr/local/share/npm/lib/node_modules/mocha/node_modules/growl/lib/growl.js:197:17)
    at Mocha.run (/usr/local/share/npm/lib/node_modules/mocha/lib/mocha.js:309:18)
    at loadAndRun (/usr/local/share/npm/lib/node_modules/mocha/bin/_mocha:300:11)
    at Object.<anonymous> (/usr/local/share/npm/lib/node_modules/mocha/bin/_mocha:311:3)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:901:3

One fix would be to use util.inspect instead of JSON.stringify in node-growl.

[tj]

hmm not sure what's going on there

[fb55]

For some reason, mocha ends up with a recursive structure. You can run the tests yourself, have a look at the link.

[tj]

don't have time to look into it right now but I'll try soon

[AvnerCohen]

@fb55 I suspect the problem is simply wrong execution of the growl "repoter"

feedy:CSSselect felix$ mocha -R growl --watch

Should be

feedy:CSSselect felix$ mocha --growl --watch

I do agree however that the API to growl should probably be a reporter just like any other...

[park9140]

Funny story I had the same thought on growl needing to be its own reporter the other day, in context to having multiple reporters.

#930

[fb55]

And that worked! Thanks, now I have a much better reason than pretty logs to use mocha :)