Return true from window.onerror handler #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mocha's own error reporter will report the error; it shouldn't be printed to the console, trigger an error badge on the Firebug toolbar button, etc.
jfirebaugh
added a commit
to jfirebaugh/konacha
that referenced
this pull request
May 27, 2013
This should be handled by mochajs/mocha#868, but PhantomJS probably still has a version of WebKit with https://bugs.webkit.org/show_bug.cgi?id=67119
|
👍 |
|
@jfirebaugh makes sense, though I'm unable to reproduce this. i'm running mocha's browser tests (https://github.com/visionmedia/mocha/blob/master/test/browser/index.html) in firefox with firebug to show errors, https://github.com/visionmedia/mocha/blob/master/test/browser/array.js#L29 fails. yet the error doesn't bubble up. i even threw |
travisjeffery
pushed a commit
that referenced
this pull request
Dec 7, 2013
Return true from window.onerror handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocha's own error reporter will report the error; it shouldn't be printed to
the console, trigger an error badge on the Firebug toolbar button, etc.