Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kani's test suite requires universal-ctags but doesn't report that when the test fails #1256

Closed
pnkfelix opened this issue Jun 7, 2022 · 1 comment · Fixed by #1261
Closed
Labels
[C] Bug This is a bug. Something isn't working.

Comments

@pnkfelix
Copy link
Contributor

pnkfelix commented Jun 7, 2022

I tried the follow command line invocation:

./scripts/kani-regression.sh

with a check out at commit 5d206d6

I expected to see this happen: A clean test suite run.

Instead, this happened: A single test failure:

[...]
subprocess.CalledProcessError: Command '['ctags', '-n', '-f', '-', '/media/pnkfelix/FormalMethods/kani/tests/cargo-kani/simple-visualize/src/main.rs']' returne\
d non-zero exit status 1.

------------------------------------------
stderr:
------------------------------------------
   Compiling simple-visualize v0.1.0 (/media/pnkfelix/FormalMethods/kani/tests/cargo-kani/simple-visualize)
    Finished dev [unoptimized + debuginfo] target(s) in 0.22s
Error: cbmc-viewer exited with status exit status: 1

------------------------------------------



failures:
    [cargo-kani] cargo-kani/simple-visualize/main.expected

Eventually I read and re-read the messages and then tried running ctags myself, and discovered that the default ctags on my machine (which I suspect emacs installed) does not support the -n option.

It would be nice if the Kani test harness detected this and asked me to install universal-ctags, rather than failing in this obscure manner.

@pnkfelix pnkfelix added the [C] Bug This is a bug. Something isn't working. label Jun 7, 2022
@zhassan-aws
Copy link
Contributor

Thanks for filing this issue, @pnkfelix! A newer version of CBMC viewer (which is one of Kani's dependencies) addressed the ctags issue, by adding support for multiple versions of ctags. We will bump the CBMC viewer version to bring in this fix for our next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] Bug This is a bug. Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants