Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce code duplication between litani and compiletest. #390

Closed
bdalrhm opened this issue Aug 5, 2021 · 1 comment
Closed

Reduce code duplication between litani and compiletest. #390

bdalrhm opened this issue Aug 5, 2021 · 1 comment
Assignees
@adpaco-aws
Labels
[I] Refactoring / Clean Up Refactoring or cleaning up of existing code

Comments

@bdalrhm
Copy link
Contributor

bdalrhm commented Aug 5, 2021

Code in src/tools/dashboard/src/util.rs contains a lot of code copied from compiletest. We should consider porting all the tests from compiletest to litani. This will give us the benefit of having a unified interface for both test suites and examples from Rust books.
@bdalrhm bdalrhm self-assigned this Aug 5, 2021
@adpaco-aws adpaco-aws assigned adpaco-aws and unassigned bdalrhm Sep 27, 2021
@celinval celinval added [I] Refactoring / Clean Up Refactoring or cleaning up of existing code and removed Area: testing labels Nov 9, 2022
@adpaco-aws
Copy link
Contributor

This isn't needed anymore (see #3123).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adpaco-aws adpaco-aws

Labels
[I] Refactoring / Clean Up Refactoring or cleaning up of existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@celinval @adpaco-aws @bdalrhm