Add configuration parameters to Bus Terminal definition (low-cut) #221
+106
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmenne-dspace
added
common
msuevern
requested changes
Dec 10, 2024
msuevern
approved these changes
Dec 17, 2024
|
FMI-Design Meeting: |
klausschuch
reviewed
Dec 18, 2024
klausschuch
reviewed
Dec 19, 2024
klausschuch
reviewed
Dec 19, 2024
klausschuch
force-pushed
the
217-network-parameters-should-be-moved-to-the-bus-terminal
branch
from
ac0210d to
94c0665
Compare
klausschuch
reviewed
Dec 19, 2024
| ---- | ||
|
|
||
| This structural parameter is mandatory for Network FMUs only. | ||
| A Bus Simulation (FMU) does not require this structural parameter. | ||
| A Bus Simulation FMU might indicate via a variable with memberName=<<low-cut-can-bus-notification-parameter, `BusNotifications`>> in the CAN Bus Terminals whether it sends bus notifications or not. |
There was a problem hiding this comment.
@bmenne-dspace should we make this mandatory, by changing the might to shall?
I think it wouldn't be a big burden for Bus Simulation FMU exporters to always expose such a variable.
There was a problem hiding this comment.
I think optional is fine, because if its missing then its automatically "false". BTW: I think we should add the "to participate in an importer parameter propagation feature." sentence again
bmenne-dspace
commented
Dec 19, 2024
| @@ -612,21 +611,19 @@ If a Network FMU does not support wake up, this operation can be ignored on the | |||
| |==== | |||
|
|
|||
| ===== Network Parameters [[low-cut-can-network-parameters]] | |||
| By using configuration parameters on Bus Terminal level, Network FMUs can be parameterized by the user or the Bus Simulation (by using e.g. the parameter propagation mechanism). | |||
| This chapter specifies the configuration parameters that each CAN-specific Network FMU shall provide. | |||
| This chapter defines parameters that Network FMU might provide to configure CAN-specific behavior. | |||
There was a problem hiding this comment.
Here we should mention that its is the config terminal within a bus terminal context
bmenne-dspace
commented
Dec 19, 2024
| If the Network FMU shall be configured to handle responses in the form of <<low-cut-can-confirm-operation, `Confirm-`>>, <<low-cut-can-bus-error-operation, `Bus Error-`>> and <<low-cut-can-arbitration-lost-operation, `Arbitration Lost`>> operations, the <<low-cut-can-bus-notification-parameter, `BusNotifications`>> configuration parameter shall be set to `true`. | ||
| A Network FMU must always be able to handle the case that the Bus Simulation does not provide <<low-cut-can-confirm-operation, `Confirm-`>>, <<low-cut-can-bus-error-operation, `Bus Error-`>> or <<low-cut-can-arbitration-lost-operation, `Arbitration Lost`>> operations. | ||
| Since a Bus Simulation is allowed to provide bus notification regardless of the <<low-cut-can-bus-notification-parameter, `BusNotifications`>> configuration parameter, Network FMUs must silently ignore such notifications if the value of <<low-cut-can-bus-notification-parameter, `BusNotifications`>> is set to `false` or the parameter is omitted. + | ||
| Therefore, a parameter with memberName=<<low-cut-can-bus-notification-parameter, `BusNotifications`>> can be added to a CAN Bus Terminal. + |
There was a problem hiding this comment.
To the "sub" config terminal .... thats why I called it "configuration parameter"
bmenne-dspace
commented
Dec 19, 2024
| If a Network FMU supports bus notifications, the <<low-cut-can-bus-notification-parameter, `BusNotifications`>> parameter shall be exposed. | ||
| The default value of this parameter shall be `false`. + | ||
| _[The default value `false` allows a simple integration of Network FMUs to simulation scenarios where <<low-cut-can-confirm-operation, `Confirm-`>>, <<low-cut-can-bus-error-operation, `Bus Error-`>> or <<low-cut-can-arbitration-lost-operation, `Arbitration Lost`>> operations are not used.]_ | ||
|
|
There was a problem hiding this comment.
"A Network FMU must always be able to handle the case that the Bus Simulation does not provide <<low-cut-can-confirm-operation, Confirm->>, <<low-cut-can-bus-error-operation, Bus Error->> or <<low-cut-can-arbitration-lost-operation, Arbitration Lost>> operations." missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.