-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve marking and tagging of rules in the standard text #1823
Comments
From my notes of the meeting, this issue can be used to raise areas which are unclear in the Standard, where the formal rules are therefore uncertain - in the hope that these can be clarified. I will try to add one comment for each distinct aspect that could be clarified, rather than raising separate issues for each one. |
The definition of continuous-time states is confusing. The mathematical model (Table 4) refers to them as Currently, the formal model tries to derive the continuous-time states from the ModelVariables, looking for Floats that are "continuous" (or default variability) that also have a derivative variable. But perhaps the continuous-time states ought to be derived from those listed in the There is a similar comment about the "continuous state derivatives". |
The rules about the inheritance of model variable fields from any declared types could be clearer. This is mentioned in Table 21, but presumably not all fields are inherited from their types - "name" clearly isn't inherited; "definition" could be, though wouldn't be sensible? "annotations" could be, but again, that wouldn't be sensible? Clock's "intervalVariability" is mandatory in both the type and the variable, so the type field can have no effect? Then, it would help if it was made clear that rules about various variable field values apply to the "effective" values of those fields after the inheritance with any derivedTypes have been resolved (assuming that's true!). The example I gave in the talk was that the "min <= max" rule hides the fact that either value may have come from the type, or may have defaulted to a MIN/MAX value for the type. |
A small point, but Table 15 explains that the "name" field of type definitions must be unique within both the list of type definitions and the list of variables. The corresponding entry in Table 17, for variables, does not mention this extra uniqueness. It probably should. Section 2.4.7.3 about variable aliases says their names must be "unique among all variables and variable aliases". So does that mean that the names of types, variables and aliases form three disjoint sets? If so, wording should probably be tightened. The formal rules will currently allow a type name to be the same as an alias name. |
Looking at the To quote the conclusion of our email: "So now the rules say that a The wording in these sections could clarify this. |
The discussion of min/max in Table 15 with Enumerations gives an example of name/value |
according to the discussion in https://github.com/modelica/fmi-design/blob/master/Meetings/2022/2022-10-25_27-F2F-FMI-Design-Meeting/minutes.adoc in order to be able to create better references to violation of rules in checkers
The text was updated successfully, but these errors were encountered: