Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial problems in the SSP 2.0 draft documentation #47

Closed
UKiffmeier opened this issue Oct 25, 2024 · 3 comments
Closed

Editorial problems in the SSP 2.0 draft documentation #47

UKiffmeier opened this issue Oct 25, 2024 · 3 comments

Comments

@UKiffmeier
Copy link

UKiffmeier commented Oct 25, 2024 •
edited
Loading

During the last days I have reviewed the current version of the SSP 2.0 documentation and found some editorial problems. The problems mainly concern:

  • The description of the attribute MetaData.source and MetaData.sourceBase [section 4.5.4]
  • Duplicate description texts [section 5.1, section 5.2.1]

See comments in the attached PDF file.
SystemStructureAndParameterization20-alpha.2024-10-15.Review.pdf
Some if the comments in the PDF were already solved by Pierre's PR #44 and PR #45.
@UKiffmeier
Copy link
Author

I have created pull request #48 with possible fixes for the above mentioned problems.

@beutlich
Copy link
Member

beutlich commented Nov 8, 2024

Can this be closed after #48 got closed?

@UKiffmeier
Copy link
Author

I will close this issue since all findings are addressed with PR #44, PR #45, and PR #48.
@beutlich : FYI.

@UKiffmeier UKiffmeier closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beutlich @UKiffmeier