-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop invoking setup.py directly #147
Conversation
Thanks. The reason I've been delaying this change is a github bug that causes the repo to no longer be recognized as a python package losing all links to dependencies and projects depending on moderngl-window. If this is still an issue we still need a setup.py in the repo at the very least. I could try to merge this and see what happens, |
That's curious. Do you want me to add back a minimal |
Nah. Let's just see what happens. Should be easy to add a skeleton setup.py if needed 😄 Just need to find a good time. Very soon. |
Note to self: Also check docs |
Kind of forgot about this. Will merge it in next next release. I'll fix the conflcs, so just let this one linger. |
I'll try to salvage this PR to respect the time you spent on this. Seems the simplest way it to merge in master, tweak a bit and squash it. |
Merged two years later. Better now than never 😆 |
I saw that this project made use of
setup.py
as well as a number ofrequirements.txt
files for setting up environments. The general recommendation is to no longer invokesetup.py
directly (find a good recap here), so I've made some changes to the build configuration in case you're interested.I have updated the instructions in the README but have not modified the CHANGELOG.
I also noted some more things as I was doing this:
black
for formatting, andpre-commit
for automatic formatting (and linting), and to integratepre-commit
with the CI/CD. I could set this up for you if you'd like.tox
in GH actions) but unsuccessfully so; if this would be of interest, however, I could try a bit further.