Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The title command breaks the bot temporarily in that channel by setting "User ID" to -1 #3151

Closed
ghost opened this issue Apr 28, 2022 · 10 comments · Fixed by #3166
Closed

The title command breaks the bot temporarily in that channel by setting "User ID" to -1 #3151

ghost opened this issue Apr 28, 2022 · 10 comments · Fixed by #3166
Labels
maybe: bug An unconfirmed bug staged Staged for next version

Comments

@ghost
Copy link

ghost commented Apr 28, 2022

Bot Version

4.0 dev9

How are you hosting Modmail?

Other

Error Logs

NA

Screenshots

No response

Additional Information

By default, the bot shows the first message of the modmail in the logs channel, but by using the title command, it used to set that instead. No error logs.

@ghost ghost added the maybe: bug An unconfirmed bug label Apr 28, 2022
@ghost
Copy link
Author

ghost commented Apr 29, 2022

image

If it helps, look at the user id it set it to after using the title command.

@ghost
Copy link
Author

ghost commented Apr 29, 2022

Tested in another thread, the bot seems to change back the channel name! Attached audit logs and me changing the name. I suspect this is the reason for #3150 The bot cant close the channel without the user ID being proper in the topic

image
image
image

@ghost
Copy link
Author

ghost commented Apr 30, 2022

Its somehow always returning -1 https://github.com/kyb3r/modmail/blob/c6ed564db714c3296a74046ac98df2ef27bcc2c8/core/utils.py#L310

Pretty sure it was broken in #3111

@ghost
Copy link
Author

ghost commented Apr 30, 2022

@Jerrie-Aries Since you did this ^ you probably have a better idea around this. I have tried combing through but only if I understood regex better

@ghost ghost changed the title Title command doesnt show up in the logs channel The title command breaks the bot temperoaily in that channel by setting "User ID Apr 30, 2022
@ghost ghost changed the title The title command breaks the bot temperoaily in that channel by setting "User ID The title command breaks the bot temperoaily in that channel by setting "User ID" to -1 Apr 30, 2022
@ghost ghost changed the title The title command breaks the bot temperoaily in that channel by setting "User ID" to -1 The title command breaks the bot temporarily in that channel by setting "User ID" to -1 Apr 30, 2022
@fourjr
Copy link
Collaborator

fourjr commented May 3, 2022

@Cordila does this always happen for this particular user? (958407376451567717)

I'm unable to find a consistent reproduction method

@ghost
Copy link
Author

ghost commented May 4, 2022

I am unable to find a constant reproduction either, but I can confirm this happens with me. Funny part being this doesnt happen when I run in the Test server. Maybe some config I have is interfering? Let me try clean updating to dev14 and get back to you.

image
ID: 705769248034914314

@ghost
Copy link
Author

ghost commented May 4, 2022

Still having the same issue even after updating.

@JeDaYoshi
Copy link

Having the same issue in the latest commit too.

@ghost
Copy link
Author

ghost commented May 4, 2022

Here is a user ID it worked for properly
756407638744629249

@JeDaYoshi
Copy link

I don't think it's something specific to certain user IDs not working.
For example, it did not work at first for my account, but did on further attempts.

@fourjr fourjr linked a pull request Jul 3, 2022 that will close this issue
@fourjr fourjr added the staged Staged for next version label Jul 3, 2022
@ghost ghost closed this as completed Sep 6, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maybe: bug An unconfirmed bug staged Staged for next version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants