Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernjs v2.60.0: Remote type hints are not being correctly extracted in the HOST #2949

Closed
5 tasks done
GiancarlosIO opened this issue Sep 12, 2024 · 4 comments
Closed
5 tasks done

Comments

@GiancarlosIO
Copy link

Describe the bug

Hi there! Following this issue #2933 I have noticed now that the types in the host app are not being correctly extracted or generated:

image

Reproduction

https://github.com/GiancarlosIO/module-federation-error

Used Package Manager

pnpm

System Info

System:
    OS: Windows 11 10.0.22631
    CPU: (32) x64 Intel(R) Core(TM) i9-14900K
    Memory: 12.47 GB / 31.75 GB
  Binaries:
    Node: 20.17.0 - ~\AppData\Local\fnm_multishells\4800_1726121307022\node.EXE
    npm: 10.8.2 - ~\AppData\Local\fnm_multishells\4800_1726121307022\npm.CMD
    pnpm: 9.8.0 - ~\AppData\Local\fnm_multishells\4800_1726121307022\pnpm.CMD
  Browsers:
    Edge: Chromium (128.0.2739.42)
    Internet Explorer: 11.0.22621.352

Validations

@2heal1
Copy link
Member

2heal1 commented Sep 13, 2024

i find the reason , i will fix it

@2heal1
Copy link
Member

2heal1 commented Sep 13, 2024

For now , you can remove distPath in modern.config.ts and remove build/static in module-federation.config.ts to skip the issue temp

@2heal1
Copy link
Member

2heal1 commented Sep 19, 2024

hey , try to upgrade @module-federation/modern-js@0.6.6

@GiancarlosIO
Copy link
Author

OMGGG!

Thanks @2heal1!!!

Now it works super duper good. It even hot reloads the types, awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants