Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the noVerify option when getting paths #38

Open
hrchu opened this issue Sep 18, 2018 · 2 comments
Open

Provide the noVerify option when getting paths #38

hrchu opened this issue Sep 18, 2018 · 2 comments

Comments

@hrchu
Copy link
Member

hrchu commented Sep 18, 2018

https://github.com/mogilefs-moji/moji/blob/master/src/main/java/fm/last/moji/MojiFile.java#L107

MojiFIle.getPaths() has no noVerify parameter

https://github.com/mogilefs-moji/moji/blob/master/src/main/java/fm/last/moji/tracker/impl/TrackerImpl.java#L56

We hard code false here.

@massdosage
Copy link
Member

@visheshdembla sounds good, we'd be happy to accept a PR. I'm thinking we keep the current getPaths() method as is but provide an overloaded versions which takes the noVerify value as a param. Make sense?

@hrchu
Copy link
Member Author

hrchu commented Dec 17, 2019

If the "no verify" option is set, the mogilefsd tracker doesn't verify that the first item returned in the list is up/alive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants