Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ml-testing-toolkit-ui] > v15 release has poor performance when running an outbound test collection #3113

Closed
kleyow opened this issue Feb 4, 2023 · 3 comments
Assignees
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it oss-ttk Related to the Mojaloop testing toolkit

Comments

@kleyow
Copy link

kleyow commented Feb 4, 2023

Summary:
The TTK UI when running a test collection takes an abnormally to process websocket outbound progress messages and display them.

Severity:
(Low, Medium, High)

Priority:
(Critical, Medium, Low)

Expected Behavior
The TTK should have similar speed as with v14

Steps to Reproduce

  1. Use funtional test enviorment found in sdk-scheme-adapter
  2. Add console.time/timeEnd to https://github.com/mojaloop/ml-testing-toolkit-ui/blob/master/src/views/outbound/OutboundRequest.jsx#L250 code block
  3. Build image and docker-compose up
  4. Run GP collection
  5. Repeat process on both v15 and v14

OutboundRequest.jsx:299 handleIncomingProgress1: 363.741943359375 ms
16:59:12.854 OutboundRequest.jsx:299 handleIncomingProgress1: 363.191162109375 ms
16:59:13.211 OutboundRequest.jsx:299 handleIncomingProgress1: 326.751953125 ms
16:59:13.565 OutboundRequest.jsx:299 handleIncomingProgress2: 331.744140625 ms
16:59:13.913 OutboundRequest.jsx:299 handleIncomingProgress2: 327.23193359375 ms
16:59:14.253 OutboundRequest.jsx:299 handleIncomingProgress2: 325.971923828125 ms
16:59:14.754 OutboundRequest.jsx:299 handleIncomingProgress2: 318.846923828125 ms
16:59:15.100 OutboundRequest.jsx:299 handleIncomingProgress2: 330.16796875 ms

OutboundRequest.jsx:303 handleIncomingProgress1: 920.82080078125 ms
17:05:39.899 OutboundRequest.jsx:303 handleIncomingProgress1: 926.431884765625 ms
17:05:40.890 OutboundRequest.jsx:303 handleIncomingProgress1: 973.029052734375 ms
17:05:41.918 OutboundRequest.jsx:303 handleIncomingProgress1: 1010.11669921875 ms
17:05:42.901 OutboundRequest.jsx:303 handleIncomingProgress2: 970.47607421875 ms
17:05:43.858 OutboundRequest.jsx:303 handleIncomingProgress2: 942.7080078125 ms
17:05:44.925 OutboundRequest.jsx:303 handleIncomingProgress2: 1042.35302734375 ms
17:05:46.027 OutboundRequest.jsx:303 handleIncomingProgress2: 978.429931640625 ms
17:05:48.085 OutboundRequest.jsx:303 handleIncomingProgress2: 941.781982421875 ms

The UI takes roughly 3x the time to process incoming outbound progress from v14->v15 for some reason.

Specifications

  • Component (if known):
  • Version:
  • Platform:
  • Subsystem:
  • Type of testing:
  • Bug found/raised by:

Notes:

  • Severity when opened:
  • Priority when opened:
@kleyow kleyow added the bug Something isn't working or it has wrong behavior on a Mojaloop Core service label Feb 4, 2023
@elnyry-sam-k elnyry-sam-k added oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it oss-ttk Related to the Mojaloop testing toolkit to-be-refined This story is ready to be groomed labels Feb 4, 2023
@kleyow
Copy link
Author

kleyow commented Feb 7, 2023

I believe I have narrowed this story down to this antd issue ant-design/ant-design#39746 and this commit vijayg10/ml-testing-toolkit-ui@6f63764

@kleyow
Copy link
Author

kleyow commented Feb 8, 2023

Another issue talking about antd performance ant-design/ant-design#39167

@elnyry-sam-k
Copy link
Member

@kleyow feel free to update the estimate

@elnyry-sam-k elnyry-sam-k removed the to-be-refined This story is ready to be groomed label Feb 9, 2023
@kleyow kleyow closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it oss-ttk Related to the Mojaloop testing toolkit
Projects
None yet
Development

No branches or pull requests

2 participants