Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using new tilelive interface #73

Open
nyurik opened this issue Mar 31, 2017 · 2 comments
Open

Consider using new tilelive interface #73

nyurik opened this issue Mar 31, 2017 · 2 comments

Comments

@nyurik
Copy link

nyurik commented Mar 31, 2017

Hi, I am thinking of refreshing tilelive API with a new function that allows a more generic, Promise based way of requesting data: Promise<object> getAsync(object). I posted my thoughts in mapbox/tilelive#189 and an implementation that would allow to use all the older components with the new interface, or newer ones with the old one in https://github.com/kartotherian/tilelive-promise

@mojodna
Copy link
Owner

mojodna commented Mar 31, 2017

I've made some comments in the tilelive issue w/ some of my opinions.

In short, though, what's the benefit of changing?

@nyurik
Copy link
Author

nyurik commented Mar 31, 2017

Thanks! First, this is not a change, but rather enhancement - people can continue using the existing interface. The benefits:

  • ability to pass additional parameters through the stack callchain. E.g. language, licencekey, ...
  • ability to handle non-tile requests like snapshots (custom area of the map with the given width/height)
  • ability to integrate related services using the same pipeline (basically treating tilelive as a generic dependency container) - for example in Wikipedia, Kartotherian can get geojson for a specific area, and that same geojson could be used as an extra layer in the snapshot service. Another example - simple-style markers (pushpins) - you set marker, color, icon size, and scaling, and get back an image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants