Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timex usage? #216

Closed
MeerKatDev opened this issue Mar 30, 2021 · 1 comment · Fixed by #217
Closed

Timex usage? #216

MeerKatDev opened this issue Mar 30, 2021 · 1 comment · Fixed by #217

Comments

@MeerKatDev
Copy link

Hi, I just started using this lib, looks promising! :) I just have a question, why is Timex needed in this library? I can't see any use of it, and it's a big library, which could be easily superseded by elixir's Calendar API.

@cpjolicoeur
Copy link
Member

cpjolicoeur commented Mar 31, 2021

@MeerKatDev It appears that you are correct. Torch no longer uses the Timex library and its inclusion in our mix now seems to be vestigial. We will cut a new release soon with it's removal.

Just note that Timex is a sub-dependency of Filtrex which Torch does use extensively. So it will still be a transitive dependency of Torch, just not a direct dependency.

@cpjolicoeur cpjolicoeur changed the title Times usage? Timex usage? Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants