Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing requirements in README prerequisites #10

Open
dennishendriksen opened this issue Oct 29, 2020 · 1 comment
Open

Missing requirements in README prerequisites #10

dennishendriksen opened this issue Oct 29, 2020 · 1 comment

Comments

@dennishendriksen
Copy link
Contributor

Opening the project in PyCharm shows the following notification:
image

pandas, nose and parameterized are not listed in the README prerequisites.

In https://github.com/molgenis/capice/ the Python library requirements are listed in requirements.txt. Would that be useful for this repository as well? We recently ran into issue molgenis/capice#4 which makes me wonder if version numbers should be specified for pandas, nose and parameterized as well?

@marikaris
Copy link
Collaborator

marikaris commented Oct 29, 2020

The requirements can be found here:

install_requires=['molgenis-py-client>=2.1.0', 'progressbar2==3.39.3', 'termcolor==1.1.0', 'yaspin==0.14.3', 'pandas'],

and here:
tests_require=['nose', 'parameterized']

That's the place I would look for them. If that isn't sufficient, I can add them to a requirements.txt, but it wouldn't be the first place for me to look.

I agree about the version numbers. I will look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants