Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add storage docs snippets #205

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Conversation

pgautier404
Copy link
Collaborator

This commit adds API snippets to the docs example. They will be consumed by our public dev docs, which will be updated in another PR in that repository.

@pgautier404 pgautier404 requested review from rishtigupta and a team July 16, 2024 20:54
@pgautier404 pgautier404 force-pushed the add-storage-docs-snippets branch from 35e1076 to 2d516e5 Compare July 16, 2024 22:35
@pgautier404 pgautier404 force-pushed the add-storage-docs-snippets branch from 2d516e5 to 611919b Compare July 16, 2024 22:45
Copy link
Contributor

@rishtigupta rishtigupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@@ -21,6 +21,6 @@ You will likely need to run this only once:
## Run Integration Test

```bash
export TEST_AUTH_TOKEN=<YOUR_AUTH_TOKEN>
export TEST_AUTH_TOKEN=<YOUR_API_KEY>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: rename to TEST_API_KEY?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a note to do that in a followup, thanks.

@pgautier404 pgautier404 merged commit 1458202 into main Jul 17, 2024
6 checks passed
@pgautier404 pgautier404 deleted the add-storage-docs-snippets branch July 17, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants