Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sorted set remove elements #227

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

malandis
Copy link
Collaborator

Adds the sorted set remove elements api, documentation, response
types, and integration tests.

Adds the sorted set remove elements api, documentation, response
types, and integration tests.
Copy link
Contributor

@nand4011 nand4011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny comment nits that can wait for the next pr.

* will provide the result of the sorted set remove elements operation upon a blocking call to
* wait.
* <code>$response = $responseFuture->wait();</code><br />
* The response represents the result of the sorted set remove element operation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The response represents the result of the sorted set remove element operation.
* The response represents the result of the sorted set remove elements operation.

src/Cache/CacheClient.php Show resolved Hide resolved
@malandis malandis merged commit 1f44343 into main Oct 17, 2024
5 checks passed
@malandis malandis deleted the feat/sorted-set-remove-elements branch October 17, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants