feat: add flags for toggling inclusivity on fetchByScore scores #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add $inclusiveMin and $inclusiveMax to sortedSetFetchByScore to allow callers to toggle whether the min and max scores should be inclusive or exclusive. They default to inclusive. Add tests for the flags. Change the behavior for an unrecognized sort order from defaulting to ascending to returning an error. Make $order not nullable. There isn't a reason for it to be null and it has a default argument.
rishtigupta
approved these changes
Oct 21, 2024
| if (!function_exists('validateSortedSetOrder')) { | ||
| function validateSortedSetOrder(int $order): void | ||
| { | ||
| if ($order != SORT_ASC && $order != SORT_DESC) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add $inclusiveMin and $inclusiveMax to sortedSetFetchByScore to allow callers to toggle whether the min and max scores should be inclusive or exclusive. They default to inclusive.
Add tests for the flags.
Change the behavior for an unrecognized sort order from defaulting to ascending to returning an error.
Make $order not nullable. There isn't a reason for it to be null and it has a default argument.