chore: add Lambda configuration with values ported from nodejs #251
Conversation
| $grpcConfig = new StaticGrpcConfiguration(1100); | ||
| $transportStrategy = new StaticStorageTransportStrategy($grpcConfig, $loggerFactory, self::$maxIdleMillis); |
There was a problem hiding this comment.
iirc, the main difference in the lambda config was that keepalives were turned off. should we also add the keepalive setting to the grpc config and turn them off here?
There was a problem hiding this comment.
Yeah, the keepalives were causing errors with infrequently invoked lambdas. If you want to add that in a future pr, we should get rid of the v1 config for now and only use latest.
There was a problem hiding this comment.
Good to know, thanks. I'll add that in.
There was a problem hiding this comment.
Ok, I added the keepalive params into the gRPC config before realizing that keepalive is opt-in. The nodejs Lambda configuration just omits the keepalive parameters to use the gRPC defaults. So the Lambda config is good to go as-is and we're free to add keepalives to new configs and new versions of the existing configs in the future as we see fit.
Yep, that was exactly what I was thinking. |
No description provided.