New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add docstrings #104

Merged

anitarua merged 11 commits into main from docstrings

Dec 13, 2023

Collaborator

anitarua commented Dec 13, 2023 •

edited

Loading

Addresses #77

anitarua added 5 commits

December 12, 2023 15:13


          chore: add config and error docstrings

01adb2c


          audited TopicClient docstrings

91c3b83


          audit CacheClient docstrings and make delete publicly usable

a0e753f


          add basic example to CacheClient and TopicClient config docstrings

e43dc15


          added docstrings for response types

bddddcd

anitarua requested a review from pgautier404

December 13, 2023 01:08

pgautier404 reviewed

View reviewed changes

Sources/Momento/config/CacheConfiguration.swift Outdated Show resolved Hide resolved


          change wording from enums to classes

65883b0

Co-authored-by: pgautier404 <pgautier404@users.noreply.github.com>

pgautier404 reviewed

View reviewed changes

Sources/Momento/config/TopicConfiguration.swift Outdated Show resolved Hide resolved


          update more wording from enums to classes

51ad7a2

Co-authored-by: pgautier404 <pgautier404@users.noreply.github.com>

pgautier404 reviewed

View reviewed changes

Sources/Momento/messages/responses/cache/control/ListCaches.swift Outdated Show resolved Hide resolved


          docstrings example for listCaches should print cache names

6c2393b

Co-authored-by: pgautier404 <pgautier404@users.noreply.github.com>

pgautier404 reviewed

View reviewed changes

Sources/Momento/messages/responses/topics/TopicSubscribe.swift Outdated Show resolved Hide resolved

pgautier404 reviewed

View reviewed changes

Sources/Momento/messages/responses/topics/TopicSubscriptionItem.swift Outdated Show resolved Hide resolved

anitarua and others added 2 commits

December 13, 2023 09:49


          improve wording for topic subscription response type

a4a8e87

Co-authored-by: pgautier404 <pgautier404@users.noreply.github.com>


          decode binary before printing

f2e12d5

Co-authored-by: pgautier404 <pgautier404@users.noreply.github.com>

pgautier404 reviewed

View reviewed changes

Sources/Momento/CacheClient.swift Outdated Show resolved Hide resolved


          print listCaches cache names

52790fd

Co-authored-by: pgautier404 <pgautier404@users.noreply.github.com>

pgautier404 approved these changes

View reviewed changes

Collaborator

pgautier404 left a comment

anitarua merged commit bec7bcc into main

4 checks passed

anitarua deleted the docstrings branch

December 13, 2023 18:06

momento-github-actions-machine-user mentioned this pull request

chore(main): release 0.3.2 #92

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet